Add JET.jl tests for type stability#51
Merged
ChrisRackauckas merged 1 commit intoSciML:mainfrom Jan 1, 2026
Merged
Conversation
Add JET.jl as a test dependency and include static analysis tests covering all core interface functions: - hasportion for all portion types - isscimlstructure for Vector and Matrix - canonicalize for all portion types - replace for Tunable portion These tests verify type stability using @test_opt with target_modules=(SciMLStructures,) to catch any regressions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@test_optfor all core interface functions:hasportionfor all portion types (Tunable, Constants, Caches, Discrete, Initials)isscimlstructurefor Vector and Matrix typescanonicalizefor all portion typesreplacefor Tunable portionMotivation
The package is already very well-typed and type-stable. This PR adds CI tests to:
JET Analysis Results
All core functions pass JET analysis with no issues:
Test plan
Pkg.test()locally withGROUP=core- all 37 tests pass@code_warntypeshows no type instabilitiescc @ChrisRackauckas
🤖 Generated with Claude Code